fix(integrations): show error instead of infinite spinner on sentry app external install page#112432
Open
sentry-junior[bot] wants to merge 6 commits intomasterfrom
Open
fix(integrations): show error instead of infinite spinner on sentry app external install page#112432sentry-junior[bot] wants to merge 6 commits intomasterfrom
sentry-junior[bot] wants to merge 6 commits intomasterfrom
Conversation
…pp external install page When the /sentry-apps/:slug/ API returns a non-2xx response (e.g. 403 for unpublished apps where the user is not in the owner org), useApiQuery sets sentryAppLoading=false but sentryApp=undefined. The existing guard: if (sentryAppLoading || orgsLoading || !sentryApp) falls through to !sentryApp=true and renders <LoadingIndicator /> forever with no feedback to the user. Fix: destructure isError from useApiQuery and track orgsError state, then render <LoadingError> with a descriptive message for each error case — following the pattern in sentryAppDetailedView.tsx. Also adds a test covering the 403 case.
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4723c2b. Configure here.
…mmediately Deterministic errors like 403 should not be retried. Without retry: false, React Query retries 3 times with exponential backoff, showing a spinner for ~7+ seconds before displaying the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When visiting the external install page for an unpublished sentry app where the user is not in the owner org, the API returns a 403:
useApiQuerycorrectly marks the request as errored but the existing guard:hits
!sentryApp === trueand renders a<LoadingIndicator />forever with no feedback to the user. Same issue applies to any other non-2xx response (404, 500, etc.).Fix
isErrorfromuseApiQueryfor the sentry app fetchorgsErrorstate for the orgs fetch (was silently swallowed before)<LoadingIndicator />while pending; render<LoadingError />for each error casesentryAppDetailedView.tsxTest
Added a test case covering the 403 scenario.